-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2663 Kafka Streams Extension Guide #2896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
force-pushed
the
2663_quickstart
branch
from
June 19, 2019 20:39
f5ec02f
to
b60d88a
Compare
machi1990
reviewed
Jun 19, 2019
cescoffier
requested changes
Jun 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good. I've made a few comments.
Co-Authored-By: Clement Escoffier <[email protected]>
gunnarmorling
force-pushed
the
2663_quickstart
branch
2 times, most recently
from
June 20, 2019 07:47
32b42a6
to
8b88b59
Compare
* Removing superfluous RegisterForReflection configuration * Adding linebreaks to avoid overflowing listings * Adding onBackpressureDrop() * Commenting config
gunnarmorling
force-pushed
the
2663_quickstart
branch
from
June 20, 2019 07:56
8b88b59
to
08051d1
Compare
cescoffier
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cescoffier and @gsmet, here's the guide for the Kafka Streams extension. This took waaay longer than I had anticipated. Feedback very welcome! Thanks to Clement for the images. I think I'll need to do some more wiring to hook this up into the menu. Where would I do that?
I'd love if this was online tomorrow, so to ride on the 0.17.0 announcement wave. I'm also planning to write a blog post with some backgrounds on the extension and future topics like metrics and health checks of the pipeline. / CC @emmanuelbernard.