-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly address the change default name mapping strategy for @RestHeader #28851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FroMage
requested changes
Oct 26, 2022
...nt-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/headers/HeaderTest.java
Outdated
Show resolved
Hide resolved
We essentially make the first letter of every part an uppercase letter for consistence Part of quarkusio#13665
FroMage
approved these changes
Oct 26, 2022
When this is merged, I need to update #28782 |
We can do it the other way around, I don't mind at all |
geoand
added
triage/waiting-for-ci
Ready to merge when CI successfully finishes
triage/backport-2.13
triage/backport?
labels
Oct 26, 2022
Given that this passes CI while #28856 is complaining, I'll go ahead and merge this |
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items.
|
quarkus-bot
bot
added
kind/enhancement
New feature or request
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13665