Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jdk18-workarounds profile in TCKs of Rest Client #28698

Closed
wants to merge 4 commits into from
Closed

Remove jdk18-workarounds profile in TCKs of Rest Client #28698

wants to merge 4 commits into from

Conversation

alexey-anufriev
Copy link
Contributor

fixes #21248

@geoand
Copy link
Contributor

geoand commented Oct 20, 2022

Thanks for this!

Let's see what CI says

gsmet
gsmet requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is that CI doesn't actually test JDK 18+ right now given our Gradle issues.

I think this will have to be put on freeze until we get the early access build back on track.

@gsmet gsmet added the triage/on-ice Frozen until external concerns are resolved label Oct 21, 2022
@famod
Copy link
Member

famod commented Nov 13, 2022

This won't work (Gradle issues aside) because resteasy classic still hasn't upgraded to httpclient 5, see also: #21248 (comment)

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
@famod
Copy link
Member

famod commented Mar 22, 2023

Closing as per #21248 (comment)

Thanks anyway @alexey-anufriev!

@famod famod closed this Mar 22, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 22, 2023
@alexey-anufriev alexey-anufriev deleted the patch-1 branch March 22, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet requested changes

Assignees
No one assigned
Labels
area/rest-client triage/invalid This doesn't seem right triage/needs-rebase This PR needs to be rebased first because it has merge conflicts triage/on-ice Frozen until external concerns are resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up JDK 18 workarounds
4 participants
@alexey-anufriev @geoand @famod @gsmet