Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage version for Apache Commons Text #28645

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Oct 17, 2022

cc/ @gsmet & @yrodiere

We need to manage org.apache.commons:commons-text to ensure consistent version, as it's being used by several components.

I've found at least these listing it as transitive dependency:

  • Liquibase
  • io.smallrye.reactive:smallrye-reactive-messaging-kafka-test-companion
  • net.sourceforge.htmlunit:htmlunit:jar
  • org.apache.activemq:artemis-server
  • io.quarkus:quarkus-avro-deployment

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Oct 17, 2022
@famod
Copy link
Member

famod commented Oct 17, 2022

I just wanted to start working on that as it mitigates https://nvd.nist.gov/vuln/detail/CVE-2022-42889

So 👍 from me!

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2022

Failing Jobs - Building 682d3c3

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@gastaldi gastaldi merged commit 983ab03 into quarkusio:main Oct 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 18, 2022
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if you start merging stuff overnight, I'll have trouble reviewing :)

Anyway, it's fine for the only part that's relevant to me, Avro. They upgraded to 1.10.0 two weeks ago and it was just a version bump without changing any code in Avro, so I don't think this will cause any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants