Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - migrate 2 deprecated Smallrye JWT properties #28635

Merged

Conversation

michalvavrik
Copy link
Member

There is no test using non-deprecated properties. If we need to choose, io.quarkus.jwt.test.JwtCookieDevModeTestCase, JwtCookieUnitTest should prefer non-deprecated header and cookie properties.

smallrye.jwt.token.header property is deprecated and will be removed in a future version. Tests now use mp.jwt.token.header property. smallrye.jwt.token.cookie property is deprecated and will be removed in a future version. Tests now use mp.jwt.token.cookie property.

There is no test using non-deprecated properties. If we need to choose, `io.quarkus.jwt.test.JwtCookieDevModeTestCase`, `JwtCookieUnitTest` should prefer non-deprecated `header` and `cookie` properties.

`smallrye.jwt.token.header` property is deprecated and will be removed in a future version. Tests now use `mp.jwt.token.header` property.
`smallrye.jwt.token.cookie` property is deprecated and will be removed in a future version. Tests now use `mp.jwt.token.cookie` property.
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik

@sberyozkin sberyozkin merged commit f468ce7 into quarkusio:main Oct 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 17, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 17, 2022
@michalvavrik michalvavrik deleted the feature/tests-migrate-2-jwt-properties branch October 17, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants