Improve error feedback for Keycloak dev service startup #28533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Oct 12, 2022
| } else { | ||
| LOG.debugf("Realm %s resource is not available", realmPath.get()); | ||
| errors.add(String.format("Realm %s resource is not available", realmPath.get())); |
There was a problem hiding this comment.
I put the full error message here but it's actually not used, it's just a marker.
This comment has been minimized.
This comment has been minimized.
sberyozkin
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
LGTM, thanks @gsmet, sure, we can accumulate errors this way and add more useful error message along the way, sorry you had to update so many functions to pass the errors list around :-)
|
So just to make it clear: I add the errors there just as flags. The usual logger is used as I don't want to break the flow of the logging (it's important to understand what's going on). So having the errors in the list is just a nice way to say |
|
That sounds OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25809
I decided to go for something specific because this use case is actually rather specific. We need to somehow be able to propagate errors that are not fatal and actually display the full log in this case.