-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly allow mixing @QuarkusTest and @QuarkusMainTest #28499
Conversation
This comment has been minimized.
This comment has been minimized.
This is done by "restarting" the application when one test type follows the other. Fixes: quarkusio#28486
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change "in the same run" to in the same package? I have a feeling the package boundary will work, and that suggests a solution.
Does run otherwise mean build phase?
I am not sure why it worked in your case, it should not really make a difference.
It generally means |
Right.. but is that accurate? That is one hell of a constraint (that you have to go through the work to make a whole 'nother execution in the pom.xml.. yuck). What is the example where that would actually be required? |
That constraint has now been lifted :) |
For this case, yes, but the condition test (with the problematic/unclear wording) is still there. What theoretical case is it covering? And would putting that in a different package solve that case (not having x and y in the same package is something more understandable than having to create a new surefire test execution? and if it isn't, then we should say 'surefire test execution' instead of 'run') |
The condition has been amended to allow mixing these two types of tests. Changing the package should not make a difference, although the reason it did is probably test order |
See #27247 |
I feel like we're talking past each other. I get the original problem that instigated the change, so what is now left as the else path.. and why isn't the fix that you made for this case applicable to the general case? Are we just waiting for the next failure for some other conflict between types because we aren't sure? |
I'm trying to play it safe as I'm not totally convinced that all tests can play with all other tests |
This is done by "restarting" the application when one test type follows the other.
Fixes: #28486