Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-offline: initialize Maven artifact resolver with the current project dir #28463

Merged
merged 1 commit into from
Oct 12, 2022
Merged

go-offline: initialize Maven artifact resolver with the current project dir #28463

merged 1 commit into from
Oct 12, 2022

Conversation

Noonchi1004
Copy link
Contributor

@Noonchi1004 Noonchi1004 commented Oct 10, 2022 •
edited by aloubyansky
Loading

Fix #27615

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Oct 10, 2022
@aloubyansky
Copy link
Member

@Noonchi1004 thanks! Looks good. Please squash your (3) commits into one. And add Fix #27615 to the PR description. GitHub will automatically close that issue once this PR has been merged.

@Noonchi1004 Noonchi1004 changed the title Go offline project Go offline project Fix #27615 Oct 10, 2022
@Noonchi1004 Noonchi1004 changed the title Go offline project Fix #27615 Go offline project Oct 10, 2022
@Noonchi1004
Copy link
Contributor Author

Fix #27615

aloubyansky
aloubyansky requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is currently including an unrelated commit and needs a proper rebase. We discussed it with @Noonchi1004 already.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/panache area/rest labels Oct 11, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@Noonchi1004
implemented .setCurrentProject(project.getBasedir().toString()) into …
1fd35f9 
…MavenArtifactResolver in order to resolve go-offline issue, merged 3 commits to 1
@quarkus-bot

This comment has been minimized.

Sign in to view
@aloubyansky aloubyansky changed the title Go offline project go-offline: initialize Maven artifact resolver with the current project dir Oct 11, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2022

Failing Jobs - Building 1fd35f9

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@aloubyansky aloubyansky merged commit 51fe1b3 into quarkusio:main Oct 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 12, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/maven area/oidc area/panache area/rest kind/bugfix
Projects
None yet
Milestone
2.13.3.Final
Development

Successfully merging this pull request may close these issues.

Maven go-offline goal fails in multi-module builds
3 participants
@Noonchi1004 @aloubyansky @gsmet