Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mojo parameter to allow quarkus:dev to specify the add-modules clause #28395

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add a mojo parameter to allow quarkus:dev to specify the add-modules clause #28395

merged 1 commit into from
Oct 5, 2022

Conversation

cescoffier
Copy link
Member

This is required if your application uses any preview APIs, such as structured concurrency.

@cescoffier
Add a mojo parameter to allow quarkus:dev to specify the add-modules …
04d91c5 
…clause.

This is required if your application uses any preview APIs, such as structured concurrency.
@cescoffier cescoffier requested a review from geoand October 5, 2022 07:33
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Oct 5, 2022
geoand
geoand approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have something equivalent in Gradle :)

@cescoffier
Copy link
Member Author

We should probably have something equivalent in Gradle :)

Yes... sure.... but:

  1. I don't know anything about gradle
  2. it crashes as soon as I use java 19

@geoand
Copy link
Contributor

geoand commented Oct 5, 2022

Yeah, let's not hold this up :)

cc @glefloch

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 5, 2022

Failing Jobs - Building 04d91c5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit 67c435d into quarkusio:main Oct 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 5, 2022
@glefloch
Copy link
Member

glefloch commented Oct 5, 2022

Right I can take care of gradle. For java 19, Support should come soon

@geoand
Copy link
Contributor

geoand commented Oct 5, 2022

Great, thanks!

@glefloch glefloch mentioned this pull request Oct 5, 2022
Merged
@cescoffier cescoffier deleted the maven-add-modules branch October 7, 2022 11:43
@zakkak zakkak mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
2.14.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@cescoffier @geoand @glefloch @gsmet