Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-client-bom from 5.12.3 to 5.12.4 #28321

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

manusa
Copy link
Contributor

@manusa manusa commented Sep 30, 2022

Bump Kubernetes Client version for 2.13 branch (RHBQ?).

The patched version contains fixes to some of the reported problems regarding informers and their usage in operators.

I'm leaving it as a draft until the affected parties confirm that this should be merged.

/cc @metacosm @csviri @andreaTP @shawkins

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Sep 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@manusa manusa changed the title deps: Bump kubernetes-client-bom from 5.12.3 to 5.12.4 Bump kubernetes-client-bom from 5.12.3 to 5.12.4 Sep 30, 2022
@metacosm
Copy link
Contributor

Problem is I cannot complete a full JOSDK build (CI included) until this gets merged (native build won't work due to a missing method, see https://github.com/quarkiverse/quarkus-operator-sdk/actions/runs/3161338537 for more details). So while I think things are OK to be merged, I cannot be a 100% sure because CI doesn't fully pass until this is merged…

@metacosm
Copy link
Contributor

I did verify locally that things build natively correctly with this PR, though.

@metacosm
Copy link
Contributor

metacosm commented Oct 1, 2022

So I adapted the CI for the JOSDK extension so that it builds the relevant PR with this PR and everything went through OK so as far as I'm concerned, we're good to go! 🎉

@gsmet
Copy link
Member

gsmet commented Oct 1, 2022

@manusa can you get this one out of draft before Tuesday evening then? Let's include it in Quarkus 2.13.1.Final.

@manusa manusa marked this pull request as ready for review October 3, 2022 05:02
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Oct 3, 2022

Ah wait. You targeted 2.13. You shouldn't do that. I will create another PR with your commit based on main.

@gsmet gsmet closed this Oct 3, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport-2.13 labels Oct 3, 2022
@gsmet gsmet reopened this Oct 3, 2022
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Oct 3, 2022
@gsmet
Copy link
Member

gsmet commented Oct 3, 2022

Ah no, that's me being confused, sorry :).

@gsmet gsmet merged commit ba09361 into quarkusio:2.13 Oct 3, 2022
@gsmet
Copy link
Member

gsmet commented Oct 3, 2022

And merged, thanks!

@gsmet gsmet added this to the 2.13.1.Final milestone Oct 3, 2022
@manusa manusa deleted the kubernetes-client/2.13 branch October 3, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants