-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-client-bom from 5.12.3 to 5.12.4 #28321
Conversation
Signed-off-by: Marc Nuri <[email protected]>
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Problem is I cannot complete a full JOSDK build (CI included) until this gets merged (native build won't work due to a missing method, see https://github.com/quarkiverse/quarkus-operator-sdk/actions/runs/3161338537 for more details). So while I think things are OK to be merged, I cannot be a 100% sure because CI doesn't fully pass until this is merged… |
I did verify locally that things build natively correctly with this PR, though. |
So I adapted the CI for the JOSDK extension so that it builds the relevant PR with this PR and everything went through OK so as far as I'm concerned, we're good to go! 🎉 |
@manusa can you get this one out of draft before Tuesday evening then? Let's include it in Quarkus 2.13.1.Final. |
This comment has been minimized.
This comment has been minimized.
Ah wait. You targeted 2.13. You shouldn't do that. I will create another PR with your commit based on main. |
Ah no, that's me being confused, sorry :). |
And merged, thanks! |
Bump Kubernetes Client version for 2.13 branch (RHBQ?).
The patched version contains fixes to some of the reported problems regarding informers and their usage in operators.
I'm leaving it as a draft until the affected parties confirm that this should be merged.
/cc @metacosm @csviri @andreaTP @shawkins