Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Maven imports in core/deployment #28318

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 30, 2022

The Maven classes won't be available in a Gradle environment. Also install forbiddenapis to make sure they don't come back.

Relates to #28301

The Maven classes won't be available in a Gradle environment.
Also install forbiddenapis to make sure they don't come back.

Relates to quarkusio#28301
@gsmet gsmet requested a review from aloubyansky September 30, 2022 09:33
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Sep 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2022

/cc @Sanne, @yrodiere

@Sanne
Copy link
Member

Sanne commented Sep 30, 2022

LGTM, but I'll let @aloubyansky review properly.

@gsmet
Copy link
Member Author

gsmet commented Sep 30, 2022

@Sanne Yeah the bot pinged you because I removed the version in the ORM pom :). Sorry for the noise.

@Sanne
Copy link
Member

Sanne commented Sep 30, 2022

np :) was still interesting to see

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsmet

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2022

Failing Jobs - Building 49b2352

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet gsmet merged commit c75de1a into quarkusio:main Oct 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 1, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants