OIDC: Fix wait strategy not respecting timeout #28299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @sberyozkin |
sberyozkin
approved these changes
Sep 29, 2022
|
@bernardocoferre thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the log message wait strategy for Keycloak container was defined in the
QuarkusOidcContainer#configuremethod, the global Dev Services timeout was not being respected correctly.By having it defined in the GenericContainer constructor, and as the container startup timeout is set at
KeycloakDevServicesProcessor.java:341, the global timeout is not being wrongly overrided anymore.To reproduce this issue, set the global timeout to 1 second with the following configuration in the
application.properties:quarkus.devservices.timeout=PT1SAnd then run an application with Keycloak using Dev Services enabled in dev mode with the following command:
quarkus devThe application will fail to start after the default Testcontainers timeout, which is 1 minute, instead of the configured timeout of 1 second.