Register the StorkClientRequestFilter when we detect a URI starting with stork:// or storks:// #28296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
cescoffier
changed the title
geoand
approved these changes
Sep 29, 2022
Sgitario
reviewed
Sep 29, 2022
There was a problem hiding this comment.
The changes look good to me, however I think it can easily be covered by reusing this test: https://github.com/quarkusio/quarkus/blob/main/extensions/resteasy-reactive/rest-client-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/stork/StorkDevModeTest.java
aureamunoz
approved these changes
Sep 29, 2022
This comment has been minimized.
This comment has been minimized.
aureamunoz
suggested changes
Sep 29, 2022
...tive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/WebTargetImpl.java
Outdated
Show resolved
Hide resolved
|
Sorry got caught up by another urgent matter. I will have a look at the issues tomorrow morning. (And here goes my blog post...) |
This comment has been minimized.
This comment has been minimized.
Registers the StorkClientRequestFilter when we detect a URI starting with stork:// or storks://.
cescoffier
force-pushed
the
stork-registration-when-using-client-builder
branch
from
69ae399 to
1563b88
Compare
|
@Sgitario I added some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28292