Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run fireOnDataFetchError on batch errors #28285

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Run fireOnDataFetchError on batch errors #28285

merged 1 commit into from
Sep 29, 2022

Conversation

jmartisk
Copy link
Contributor

Fixes #28184

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2022

Failing Jobs - Building 0ac49b1

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

phillip-kruger
phillip-kruger approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger merged commit 8da3049 into quarkusio:main Sep 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 29, 2022
@jmartisk jmartisk deleted the main-issue-28184 branch September 30, 2022 05:48
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
area/graphql area/smallrye kind/bugfix
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.

quarkus-smallrye-graphql: @ErrorDataFetch event is not emitted in batch query
3 participants
@jmartisk @phillip-kruger @gsmet