Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the original JAR path check in the JarResultBuildStep #28259

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

aloubyansky
Copy link
Member

Fix the original JAR file check when the finalName in the Quarkus plugin is different from the one in the POM's build section. The consequence of this broken check was that the Quarkus runner JAR wasn't installed/deployed in the Maven repo.

…s different from the one in the POM's build section
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/maven labels Sep 28, 2022
@gsmet
Copy link
Member

gsmet commented Sep 28, 2022

@aloubyansky should it be backported to 2.13?

@aloubyansky aloubyansky added triage/backport-2.13 and removed area/core area/maven area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus labels Sep 28, 2022
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2022

Failing Jobs - Building 34faea6

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@aloubyansky aloubyansky added area/core area/maven area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus labels Sep 29, 2022
@gsmet gsmet merged commit 2ea8de0 into quarkusio:main Sep 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 29, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants