Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for rootless docker context #28235

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix support for rootless docker context #28235

merged 1 commit into from
Sep 28, 2022

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 27, 2022 •
edited
Loading

With the ' it returns '''unix:///run/user/1000/docker.sock' which fails the startsWith("unix://") check.

Fix up #26892

Despite being discussed in #26892 (comment) it slipped through.

@zakkak
Fix support for rootless docker context
71a0501 
With the `'` it returns `'''unix:///run/user/1000/docker.sock'` which
fails the startsWith("unix://") check.

Fix up quarkusio#26892
@zakkak zakkak requested a review from geoand September 27, 2022 19:47
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 27, 2022

Failing Jobs - Building 71a0501

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
🚫 JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-reactive

📦 integration-tests/opentelemetry-reactive

✖ io.quarkus.it.opentelemetry.reactive.OpenTelemetryReactiveClientTest.post line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <c1634c39345b7843> but was: <64055ecf02f75e0d>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 28, 2022

The CI failure seems irrelevant to the PR

@geoand
Copy link
Contributor

geoand commented Sep 28, 2022

Indeed

@zakkak zakkak merged commit aaf9b9c into quarkusio:main Sep 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 28, 2022
@zakkak zakkak deleted the 2022-09-27-fix-rootless-docker-context-support branch September 28, 2022 06:26
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core triage/flaky-test
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@zakkak @geoand @gsmet