Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notifyAll instead of notify #28213

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Use notifyAll instead of notify #28213

merged 1 commit into from
Sep 27, 2022

Conversation

stuartwdouglas
Copy link
Member

HTTP/2 could have multiple threads waiting on the connection, so we need to wake up all of them.

In future we could move to a park/unpark based approach but it would need some performance testing.

Fixes #28116

HTTP/2 could have multiple threads waiting on the connection, so we need to wake up all of them.

In future we could move to a park/unpark based approach but it would need some performance testing.

Fixes quarkusio#28116
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 27, 2022

Failing Jobs - Building eb5083b

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc-code-flow 

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 509 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/tenant-autorefresh?state=258ab5dc-e736-4f76-aeba-d4791bfa3033&session_state=ad1646dc-a808-4c63-96a1-5ef4d7c5dfc8&code=e7b5cc37-7d3f-4a8c-be9b-ebe7e79409f4.ad1646dc-a808-4c63-96a1-5ef4d7c5dfc8.28a8d6a1-c6b3-4bb8-9632-01a75389c8cf
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably ban the use of notify completely :)

@sberyozkin
Copy link
Member

The code flow test has been disabled

@geoand geoand merged commit 73ee079 into quarkusio:main Sep 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 27, 2022
@gsmet
Copy link
Member

gsmet commented Sep 27, 2022

Is it something that should be backported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VertxInputStream 10 s delay with parallel requests
4 participants