Override gRPC Context storage #28199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
force-pushed
the
fix-grpc-context-lost
branch
from
a2d1b06 to
ad9139f
Compare
This comment has been minimized.
This comment has been minimized.
The problem comes from the default gRPC context storage using a thread-local. This commit overrides the storage implementation (using the recommended method) to use the duplicated context and fallback to a thread-local.
cescoffier
force-pushed
the
fix-grpc-context-lost
branch
from
ad9139f to
b82b235
Compare
|
The oidc code flow test failure is unrelated - which will be disabled in #28209 |
Failing Jobs - Building b82b235
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/oidc-code-flow
📦 integration-tests/oidc-code-flow✖ |
gsmet
approved these changes
Sep 28, 2022
vietj
reviewed
Sep 28, 2022
| /** | ||
| * Override gRPC context storage to rely on duplicated context when available. | ||
| */ | ||
| public class ContextStorageOverride extends Context.Storage { |
There was a problem hiding this comment.
wow that's nasty (in gRPC) , the io.grpc.override.ContextStorageOverride hardcoded class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem comes from the default gRPC context storage using a thread-local.
This commit overrides the storage implementation (using the recommended method) to use the duplicated context and fallback to a thread-local.