Ignore non-existing class and resource paths during JVM test #28186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may also fix #26013 |
This comment has been minimized.
This comment has been minimized.
|
Do we need to rerun this or should we investigate? |
Some resource and class locations may not exist when resolving paths. We now ensure that these non-existing path are not added to the application root. Signed-off-by: Adler Fleurant <[email protected]>
AdlerFleurant
force-pushed
the
no-main-extension-test
branch
from
709cc64 to
33f1e6c
Compare
|
Yeah no need to push again when it's like that. Usually it's just a flaky test. We will deal with it ourselves and ping you if we think it's related to your work. We are currently working on improving the situation with flaky tests. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resource and class locations may not exist when resolving paths.
We now ensure that these non-existing paths are not added to the application root.