Update RestEasy Classic mappers and Vert.x HTTP to log messages related to 401 #28157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Sep 22, 2022
| import io.quarkus.security.AuthenticationCompletionException; | ||
|
|
||
| @Provider | ||
| public class AuthenticationCompletionExceptionMapper implements ExceptionMapper<AuthenticationCompletionException> { | ||
|
|
||
| private static final Logger log = Logger.getLogger(AuthenticationCompletionExceptionMapper.class.getName()); |
There was a problem hiding this comment.
Did you enable debug for this category?
There was a problem hiding this comment.
Yeah, I realized I missed it so converted to Draft :-), checking now with one of the tests expecting 401
| @@ -25,6 +27,8 @@ | |||
| */ | |||
| @Singleton | |||
| public class HttpAuthenticator { | |||
| private static final Logger log = Logger.getLogger(HttpAuthenticator.class); | |||
| @@ -92,6 +92,7 @@ public void accept(Throwable throwable) { | |||
| } | |||
| }); | |||
| } else if (throwable instanceof AuthenticationCompletionException) { | |||
| log.debug("Authentication has failed, returning HTTP status 401"); | |||
sberyozkin
force-pushed
the
log_401_status
branch
from
28652ba to
319b9f8
Compare
|
I enabled |
|
was not sure about lower case |
gsmet
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the OIDC refresh tests failed again today in #28142 however the raw logs show nothing related to the source of
401despite me covering all of theCodeAuthenticationMechanismcode related to producing 401.It may suggest that
401is likely reported from elsewhere, either from Vert.x HTTP or ResteasyClassic exception mappers, so here is one more and very likely the final attempt to trace it before disabling it as I really see no other sources of 401 or any reasons for it in the OIDC code:testRPInitiatedLogouttest as it might be that logging out the user from alogout-realmand then signing in to the same realm and auto-refreshing might be causing some transient side-effects in KC