Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes: Correct artifact path location #28122

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Kubernetes: Correct artifact path location #28122

merged 1 commit into from
Oct 4, 2022

Conversation

Sgitario
Copy link
Contributor

Adding dependencies like quarkus-openshift and quarkus-kubernetes-config might lead to running the Kubernetes processor when the JAR file is not correct yet.

With these changes, we'll get always the correct artifact.
Fix #28108

@Sgitario
Copy link
Contributor Author

cc @iocanel @michalvavrik

I've tested these changes in JVM and native, but I'd appreciate if you have another round to ensure that it works the same for Native before merging @michalvavrik.

@quarkus-bot

This comment has been minimized.

Sign in to view
@Sgitario Sgitario force-pushed the fix_openshift_config branch from d8245b1 to 238d5be Compare September 21, 2022 12:30
@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
Copy link
Member

Hello @Sgitario , unfortunately we are having cluster issues today, but I check once I can.

@michalvavrik
Copy link
Member

Thank you for the fix btw.

@michalvavrik
Copy link
Member

I run tests - reproducer in JVM and Quarkus QE TS in JVM/native are fixed. Reproduced failed in native mode, but it also failed when I run it with current main (exception looks not related).

@Sgitario
Copy link
Contributor Author

It seems that the current solution introduces build cycle issues: GeneratedResourceBuildItem -> JarBuildItem - > KubernetesProcessor... and again
So, I will need to find another solution.

@Sgitario Sgitario marked this pull request as draft September 22, 2022 05:13
@Sgitario Sgitario force-pushed the fix_openshift_config branch 2 times, most recently from a1a0a1d to da6b427 Compare September 22, 2022 05:49
@Sgitario Sgitario marked this pull request as ready for review September 22, 2022 05:49
@Sgitario Sgitario force-pushed the fix_openshift_config branch from da6b427 to 9595503 Compare September 22, 2022 07:26
@geoand
Copy link
Contributor

geoand commented Sep 23, 2022

Is this now ready to go @Sgitario ?

@Sgitario
Copy link
Contributor Author

Is this now ready to go @Sgitario ?

From my point of view, yes +1

@geoand geoand requested a review from iocanel September 23, 2022 07:05
@Sgitario
Kubernetes: Correct artifact path location
922948b 
Adding dependencies like `quarkus-openshift` and `quarkus-kubernetes-config` might lead into running the kubernetes processor when the JAR file is not correct yet. 

With these changes, we'll get always the correct artifact.
Fix quarkusio#28108
@Sgitario Sgitario force-pushed the fix_openshift_config branch from 9595503 to 922948b Compare September 27, 2022 07:10
iocanel
iocanel approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 28b0d97 into quarkusio:main Oct 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 4, 2022
@Sgitario Sgitario deleted the fix_openshift_config branch October 4, 2022 09:19
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees

@iocanel iocanel

Labels
area/kubernetes kind/bugfix
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.

App won't start in OpenShift due to incorrect JAVA_APP_JAR with quarkus-kubernetes-config
5 participants
@Sgitario @michalvavrik @geoand @iocanel @gsmet