Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.native-entrypoint #28097

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.native-entrypoint #28097

merged 1 commit into from
Sep 22, 2022

Conversation

Dieken
Copy link
Contributor

@Dieken Dieken commented Sep 20, 2022 •
edited by geoand
Loading

jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint from base image, so make Quarkus learn it.

Resolves #28071

@quarkus-bot

This comment was marked as resolved.

Sign in to view
@Dieken Dieken force-pushed the jib-entrypoint-inherit branch from aaa929d to e676c2a Compare September 20, 2022 15:53
@Dieken Dieken changed the title support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.native-entrypoint Support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.native-entrypoint Sep 20, 2022
@geoand
Copy link
Contributor

geoand commented Sep 20, 2022

Interesting!

Can you also update one of the integration tests to use this property so we can properly make test it?

@Dieken Dieken force-pushed the jib-entrypoint-inherit branch 2 times, most recently from 5f27c35 to 6d6af4a Compare September 21, 2022 10:51
@Dieken
Copy link
Contributor Author

Dieken commented Sep 21, 2022

Interesting!

Can you also update one of the integration tests to use this property so we can properly make test it?

I added an integration test, ./mvnw -f integration-tests/container-image clean install passed but ./mvnw -f integration-tests/container-image clean install -Dnative failed, I can't tell whether the former really passed and why the latter failed, the log is too few and ambiguous.

@geoand
Copy link
Contributor

geoand commented Sep 21, 2022

Did you try the tips mentioned here? Essentially you should use -Dstart-containers -Dtest-containers

@Dieken
Support "INHERIT" for quarkus.jib.jvm-entrypoint and quarkus.jib.nati…
74290e4 
…ve-entrypoint

jib-maven-plugin and jib-gradle-plugin both support this option to inherit entrypoint
from base image, so make Quarkus learn it.

Fixed quarkusio#28071
@Dieken Dieken force-pushed the jib-entrypoint-inherit branch from 6d6af4a to 74290e4 Compare September 21, 2022 13:53
@Dieken
Copy link
Contributor Author

Dieken commented Sep 21, 2022

Did you try the tips mentioned here? Essentially you should use -Dstart-containers -Dtest-containers

You are right, these properties start the real tests.

These tests all passed, I didn't run all tests because it's too slow.

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-appcds -Dstart-containers -Dtest-containers

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-appcds -Dstart-containers -Dtest-containers -Dnative

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-inherit -Dstart-containers -Dtest-containers

./mvnw clean install -f integration-tests/container-image/maven-invoker-way -Dinvoker.test=container-build-jib-inherit -Dstart-containers -Dtest-containers -Dnative

container-build-jib-inherit is modified from container-build-jib-appcds.

So I think everything should be ok :-)

@geoand
Copy link
Contributor

geoand commented Sep 21, 2022

Looks good, thanks!

@geoand geoand merged commit d45c048 into quarkusio:main Sep 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 22, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 22, 2022
@Dieken
Copy link
Contributor Author

Dieken commented Sep 22, 2022

https://github.com/quarkusio/quarkus/wiki/Release-Planning

2.14 will be released in Nov. , could you cherry-pick this commit into 2.13? This is a very small but useful enhancement for me :-)

@geoand

@geoand
Copy link
Contributor

geoand commented Sep 22, 2022

Yeah, I support that would be fine.

@Dieken
Copy link
Contributor Author

Dieken commented Sep 29, 2022

Quarkus 2.13.0 is released, could you backport this to 2.13.1? Thanks!

@geoand
Copy link
Contributor

geoand commented Sep 29, 2022

That's the point of the label :)

@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/container-image kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.

support quarkus.jib.jvm-entrypoint=INHERIT
3 participants
@Dieken @geoand @gsmet