Support multiple profiles

[radcortez]

Initial work to support #27760.

• Fixes Some Quarkus mode are enforcing a specific profile making it impossible to use another config profile #27760
• Fixes quarkus.profile is fixed at build time while it is documented as runtime #28176
• Fixes QUARKUS_TEST_PROFILE env variable is not honored #29944

Get rid of calls to ProfileManager#getActiveProfile and rely on the profiles list coming from SmallRye Config.

[quarkus-bot]

/cc @Sanne, @gsmet, @yrodiere

[radcortez]

/cc @ia3andy

[geoand]

What's the status of this?

Seems important to have :)

[ia3andy]

I am waiting for the CI to pass to give it a try

[geoand]

CI has passed 😉

[radcortez]

Would like some feedback from @ia3andy, since this was mainly to fix #27760.

[ia3andy]

I've tried it with different cases and it seems to work fine (and as I expect it to work).

[radcortez]

Approve? :)

[ia3andy]

LGTM!

I am not sure why this is called "initial work..." instead of "support multiple profiles"

[ia3andy]

As this PR is side-effect friendly, I think it would be wise to have another review.

@gastaldi maybe?

[geoand]

I'm going to rebase this on main to get another CI run.

[geoand]

I think we should get this in 2.14. @gsmet WDYT?

[ia3andy]

@gsmet up

[gastaldi]

Added some comments

[quarkus-bot]

Failing Jobs - Building 5cf686e

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 17 MacOS M1
✖	JVM Tests - JDK 18	Build	Failures	Logs	Raw logs
✔️	Maven Tests - JDK 11
⌛	Maven Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/reactive-messaging-hibernate-orm 

📦 integration-tests/reactive-messaging-hibernate-orm

✖ io.quarkus.it.kafka.KafkaConnectorTest.testFruits line 50 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <1> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

[radcortez]

/ping @gsmet

[ia3andy]

@radcortez I think with two approvals we can merge?

[ia3andy]

This being a big change I think making it Quarkus 3.0 might be a good idea no?

[radcortez]

@radcortez I think with two approvals we can merge?

Sure, just wanted to make sure that @gsmet was ok with this.

This being a big change I think making it Quarkus 3.0 might be a good idea no?

Hum, I thought you needed this sooner. I mean, it is a considerable change, but not so big that it requires a major version.

[ia3andy]

@radcortez, I think @gsmet had plenty of time to give an opinion on this :) I am not sure if the CI is considered as passed or not, but if it is, you can merge

[radcortez]

The CI failure is unrelated. A timeout issue.

Well, I'll be merging this then.