With disabled proactive sec., only create sec. identity when required

[michalvavrik]

fixes: #27316

When proactive security is disabled (quarkus.http.auth.proactive=false), security identity is only created (or more specifically, io.quarkus.vertx.http.runtime.security.HttpAuthenticator#attemptAuthentication is only called) when required. This behavior is expected by user (see linked issue) and was described here #27316 (comment) by @sberyozkin.

Added test io.quarkus.vertx.http.security.DisabledProactiveSecIdentityProviderTest#testAuthenticationIsNotAttempted would fail prior to this PR (tested).

[michalvavrik]

Sorry about cancelled workflow run, I'll be more careful.

[sberyozkin]

Hi Stuart @stuartwdouglas I think it is the correct solution, but double check please if you get a chance

[michalvavrik]

io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh - flaky test

[sberyozkin]

I've just merged the PR which adds a few more log messages. Unfortunately something strange is going on with the refresh token tests. Can you please rebase and have this build run again ? It is most likely unrelated but this change a very sensitive change, so we need to be 100% certain, and as it happens these tests run with the proactive authentication disabled, thanks

[michalvavrik]

@sberyozkin sure, done, let see

[quarkus-bot]

Failing Jobs - Building 76f2aa4

Status	Name	Step	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	Devtools Tests - JDK 11 Windows
✖	Devtools Tests - JDK 17	Build	Failures	Logs	Raw logs
✔️	Gradle Tests - JDK 11
✖	Gradle Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

---

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[3] line 81 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 88 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

---

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

✖ io.quarkus.gradle.QuarkusPluginFunctionalTest.canDetectClasspathChangeWhenBuilding line 98 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

✖ io.quarkus.gradle.QuarkusPluginFunctionalTest.canDetectUpToDateBuild line 58 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

---

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-reactive 

📦 integration-tests/opentelemetry-reactive

✖ io.quarkus.it.opentelemetry.reactive.OpenTelemetryReactiveClientTest.post line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <6cfc9008dc47a77e> but was: <005afaae68a80aa4>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

[sberyozkin]

@michalvavrik So that was that random test failure not related to this PR and the test failures here are not related so I think we can merge, @stuartwdouglas - ping us please if you'll have some concerns