Replace usage of NeverInline in jdbc-pgsql #27960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation relied on a graal compiler optimization to never inline a method. By doing so it tricked native-image into not including XML processing code when it's not used. Instead, use a DomHelper-local bifunction field which stays null unless the XML processing code is actually reachable. If it is, the bifunction is being set by the reachability handler and, thus, achieves the same result. Closes quarkusio#27791
|
I'm testing this with the mandrel GHA suite here: https://github.com/graalvm/mandrel/actions/runs/3060671324 |
|
Mandrel GHA shows no new failures (we were seeing failures in Data5). Remaining failures are all related to the kotlin issue. See #27300. Example failure without this patch from our nightlies: |
2 tasks
Thanks for the review! |
|
Very nice pattern, I didn't know we could do that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on a graal compiler optimization to never inline a method. By doing so it tricked native-image into not including XML processing code when it's not used.
Instead, use a DomHelper-local bifunction field which stays null unless the XML processing code is actually reachable. If it is, the bifunction is being set by the reachability handler and, thus, achieves the same result.
Closes #27791