Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the registration of @LoggingFilter classes via CDI #27917

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 14, 2022

This allows for users to configure their filters
via the usual Quarkus configuration approach.

Follows up on: #27864

P.S. This is in draft because I need to add Javadoc to the new interface and also update the logging docs with a working example.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/logging labels Sep 14, 2022
@geoand geoand mentioned this pull request Sep 14, 2022
This allows for users to configure their filters
via the usual Quarkus configuration approach.

Follows up on: quarkusio#27864
@geoand geoand marked this pull request as ready for review September 14, 2022 09:34
@geoand geoand requested a review from famod September 14, 2022 09:34
@geoand geoand requested a review from gastaldi September 14, 2022 09:34
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2022

Failing Jobs - Building a03cda3

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: devtools/cli integration-tests/smallrye-context-propagation 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppDefaults line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 98 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.mutiny.MutinyContextPropagationTest.testTransactionTCContextPropagation line 132 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

@geoand geoand merged commit 9a5bc36 into quarkusio:main Sep 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 14, 2022
@geoand geoand deleted the #27864-followup branch September 14, 2022 16:33
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/core area/documentation area/logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants