-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmallRye CP - introduce ThreadContextProviderBuildItem #27685
SmallRye CP - introduce ThreadContextProviderBuildItem #27685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I have two notes though
Firstly, this has the downside that I mentioned here. I am not sure that's something that has been considered and is acceptable?
Secondly, we should have some test for it; you can take a look at these tests for inspiration and do a similar one with your config turned off.
+1 |
7675cae
to
bf375bf
Compare
This comment has been minimized.
This comment has been minimized.
extensions/arc/deployment/src/test/java/io/quarkus/arc/test/cp/ContextProviderDisabledTest.java
Outdated
Show resolved
Hide resolved
extensions/arc/deployment/src/test/java/io/quarkus/arc/test/cp/ContextProviderEnabledTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/quarkus/smallrye/context/deployment/SmallRyeContextPropagationProcessor.java
Outdated
Show resolved
Hide resolved
Otherwise LGTM. |
bf375bf
to
4d8ecb8
Compare
This comment has been minimized.
This comment has been minimized.
Probably have to move the tests into the SRye ConProp extension? |
4d8ecb8
to
2bc2b52
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The |
...ions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ArcContextPropagationConfig.java
Show resolved
Hide resolved
- this allows for conditional registration of ThreadContextProvider
2bc2b52
to
be0322e
Compare
Failing Jobs - Building be0322e
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: core/deployment
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 644 more 📦 core/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/opentelemetry/opentelemetry/deployment
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/micrometer-prometheus and 6 more 📦 extensions/opentelemetry/opentelemetry/deployment✖
|
This PR introduces the
ThreadContextProviderBuildItem
so that it's possible to register a CPThreadContextProvider
via build item (in addition to the current service loader facility). Furhtermore, a new ArC config property is introduced -quarkus.arc.context-propagation.enabled
. This property is a temporary solution, i.e. the property itself could be removed in the future or the default value may be subject of change.