Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SmallRye Config to 2.12.0 #27660

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Update SmallRye Config to 2.12.0 #27660

merged 1 commit into from
Sep 4, 2022

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Sep 1, 2022 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file labels Sep 1, 2022
@radcortez radcortez mentioned this pull request Sep 1, 2022
Closed
@geoand
Copy link
Contributor

geoand commented Sep 2, 2022

@radcortez I assume this is now good to go?

@radcortez
Copy link
Member Author

Yes.

@radcortez radcortez force-pushed the srconfig-2.12.0 branch 2 times, most recently from 64b2b36 to 27c00da Compare September 2, 2022 07:52
@radcortez radcortez marked this pull request as ready for review September 2, 2022 07:52
gsmet
gsmet requested changes Sep 2, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jakarta update is missing.

@radcortez
Copy link
Member Author

The Jakarta update is missing.

Ah, yes. I forgot that I have to update that now as well :)

I still have to release that one. I'm doing that now.

@radcortez radcortez requested a review from gsmet September 2, 2022 09:56
@quarkus-bot

This comment has been minimized.

Sign in to view
@radcortez
Copy link
Member Author

It seems that something is breaking io.quarkus.jwt.test.PublicKeyLocationConfigTest. I'll check.

@radcortez
Copy link
Member Author

It seems that something is breaking io.quarkus.jwt.test.PublicKeyLocationConfigTest. I'll check.

Ah, this is because mp.jwt.verify.publickey.location may contain expansion variables provided on runtime. In that case, we cannot register the native image resource (the user must do that manually). In the new version of MP Config, expressions in Optional configuration do not cause the expansion to fail (which the build step was checking).

@gastaldi gastaldi merged commit f13f91c into quarkusio:main Sep 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 4, 2022
@gsmet gsmet removed this from the 2.13 - main milestone Sep 6, 2022
@gsmet gsmet added this to the 2.12.1.Final milestone Sep 6, 2022
@radcortez radcortez deleted the srconfig-2.12.0 branch December 16, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/jakarta area/smallrye kind/bugfix
Projects
None yet
Milestone
2.12.1.Final
4 participants
@radcortez @geoand @gsmet @gastaldi