Re-enable ParseOnce starting with GraalVM / Mandrel 22.2
#27462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to disable `ParseOnce` as memory usage with it enabled has improved in GraalVM 22.2. See https://docs.google.com/spreadsheets/d/15PJ1Qd7kgneuP61N1T2_AyJ3WBsbXpVHIPKbxgH1qfM/edit#gid=1672873268 for a comparison between using and not using `ParseOnce` with 22.2. Relates to oracle/graal#3435 and graalvm/mandrel#316 Fixes quarkusio#25944
Failing Jobs - Building 03ea11c
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: devtools/cli devtools/gradle/gradle-model
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin 📦 devtools/cli✖ ✖ ✖ 📦 devtools/gradle/gradle-model✖ ⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/gradle/gradle-model
! Skipped: devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin 📦 devtools/gradle/gradle-model✖ |
galderz
approved these changes
Aug 24, 2022
|
I will backport it to get some feedback from the field before 2.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to disable
ParseOnceas memory usage with it enabledhas improved in GraalVM 22.2.
See
https://docs.google.com/spreadsheets/d/15PJ1Qd7kgneuP61N1T2_AyJ3WBsbXpVHIPKbxgH1qfM/edit#gid=1672873268
for a comparison between using and not using
ParseOncewith 22.2.Relates to oracle/graal#3435 and
graalvm/mandrel#316
Fixes #25944