Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Functions documentation improvements #27438

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

loicmathieu
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation labels Aug 23, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2022

Failing Jobs - Building 831bf89

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-vertx 

📦 integration-tests/opentelemetry-vertx

io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus line 134 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CONSUMER> but was: <PRODUCER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/micrometer-prometheus 

📦 integration-tests/micrometer-prometheus

io.quarkus.it.micrometer.prometheus.ClientRequestTest.testClientRequests line 36 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@loicmathieu
Copy link
Contributor Author

Test failures seems un-related (micrometer and opentelemetry assertion failures).

@loicmathieu loicmathieu requested a review from gsmet August 25, 2022 15:40
@loicmathieu
Copy link
Contributor Author

Can someone review this one please ? @gsmet or @geoand maybe ?
I have another PR which may be in conflict so I cannot finish it untill this one is merged.

@geoand
Copy link
Contributor

geoand commented Aug 26, 2022

Although this looks correct, I don't know the details of how the docs are built, so I'll leave it to Guillaume.

@loicmathieu
Copy link
Contributor Author

I checked the generated docs for the correct replacement of attributes, but OK, let's wait for Guillaume

@loicmathieu
Copy link
Contributor Author

@gsmet can you validate this PR ? I check the generated doc for the variable replacement this should be OK.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit 7e0ba16 into quarkusio:main Aug 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 31, 2022
@loicmathieu loicmathieu deleted the gcf-doc-improvements branch August 31, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants