-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud Functions documentation improvements #27438
Conversation
Failing Jobs - Building 831bf89
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/opentelemetry-vertx
📦 integration-tests/opentelemetry-vertx✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/micrometer-prometheus
📦 integration-tests/micrometer-prometheus✖
|
Test failures seems un-related (micrometer and opentelemetry assertion failures). |
Although this looks correct, I don't know the details of how the docs are built, so I'll leave it to Guillaume. |
I checked the generated docs for the correct replacement of attributes, but OK, let's wait for Guillaume |
@gsmet can you validate this PR ? I check the generated doc for the variable replacement this should be OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.