Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java Parser 3.24.4 #27435

Closed
wants to merge 1 commit into from

Conversation

cescoffier
Copy link
Member

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Aug 23, 2022
@gsmet
Copy link
Member

gsmet commented Aug 23, 2022

OK, just so we are clear: we need this to get in a given Quarkus version and in the Kogito version that will end up in the Platform of this given Quarkus version. So let's be careful about when we merge it in both trees.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2022

Failing Jobs - Building cc539a3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 line 59 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 4 State{lastRun=4, running=true, inProgress=false, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1(KafkaDevServicesContinuousTestingTestCase.java:59)

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 line 83 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 4 State{lastRun=3, running=true, inProgress=false, run=1, passed=0, failed=1, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2(KafkaDevServicesContinuousTestingTestCase.java:83)

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: kogito-drl-quickstart kogito-quickstart 

📦 kogito-drl-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project kogito-drl-quickstart: Failed to build quarkus application

📦 kogito-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project kogito-quickstart: Failed to build quarkus application

@gsmet
Copy link
Member

gsmet commented Aug 24, 2022

@mariofusco so should we target this for the Kogito version that will go into 2.13 (i.e. our next version coming in about a month)?

/cc @evacchi

@mariofusco
Copy link
Contributor

@gsmet Are you still planning to merge this? If there isn't any other blocker please do so, we need it to also upgrade javaparser on Drools/Kogito, thanks.

@cescoffier
Copy link
Member Author

@gsmet @mariofusco what's the status of this one?

@mariofusco
Copy link
Contributor

@cescoffier I'm ready to merge the upgrade on the drools/kogito side and I was waiting for this PR to be merged before moving forward also there.
@gsmet how do you want to proceed here?

@famod
Copy link
Member

famod commented Jan 9, 2023

Coming from #30162 (dependabot update to 3.24.10), is there any progress on this?

@gsmet gsmet closed this Feb 1, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants