Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generation of Job/CronJob resources #27425

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

Sgitario
Copy link
Contributor

Fix #27024

@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the code, only the documentation.

docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/picocli.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/picocli.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/picocli.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/picocli.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/picocli.adoc Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 24, 2022

@Sgitario I think you missed some of my suggestions. GitHub displays some of them in the Conversation tab but it hides those in the middle and you have to click on 14 hidden conversations Load more.

@Sgitario
Copy link
Contributor Author

@Sgitario I think you missed some of my suggestions. GitHub displays some of them in the Conversation tab but it hides those in the middle and you have to click on 14 hidden conversations Load more.

Ops, sorry! All the suggestions are now applied.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 24, 2022

OK, I'll take it from there as I want to apply one more tab related change.

@gsmet
Copy link
Member

gsmet commented Aug 24, 2022

I squashed the commits and also used the tabs for pom.xml/build.gradle alternatives in the Picocli doc.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good on the doc side, I will let @iocanel check the code itself.

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Aug 29, 2022

@iocanel mind taking a look at this?

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check that working with existing resources dont throw CME. A test maybe?

@Sgitario
Copy link
Contributor Author

@iocanel as far I know, the decorators are applied sequentially, so don't think we should worry about concurrent modifications. Moreover, we're doing the same in other decorators. However, to be extra safe, I've added this test https://github.com/quarkusio/quarkus/blob/389d91b8170a30248954788d41201f80fc8c8c31/integration-tests/kubernetes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/KubernetesWithExistingCronJobResourceTest.java.

Btw, after rebasing the branch, I spotted an issue when applying the matching labels. I've already fixed it, but I need to fix it in Dekorate as well.

@Sgitario Sgitario requested a review from iocanel September 12, 2022 12:01
Sgitario added a commit to Sgitario/dekorate that referenced this pull request Sep 12, 2022
@quarkus-bot

This comment has been minimized.

Sgitario added a commit to dekorateio/dekorate that referenced this pull request Sep 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 19, 2022

Failing Jobs - Building 52dfe16

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-reactive 

📦 integration-tests/opentelemetry-reactive

io.quarkus.it.opentelemetry.reactive.OpenTelemetryReactiveClientTest.post line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <44fcf8d1b6a91bd3> but was: <500e364eaa3388ac>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: optaplanner-quickstart 

📦 optaplanner-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project optaplanner-quickstart: Failed to build quarkus application

@iocanel
Copy link
Contributor

iocanel commented Sep 21, 2022

@iocanel as far I know, the decorators are applied sequentially, so don't think we should worry about concurrent modifications. Moreover, we're doing the same in other decorators. However, to be extra safe, I've added this test

It doesn'matter how you apply the decorators. Modifying a list while iterating it will result in this exception. I think the same applies to stream. Eitherway, having a test is good enough for me.

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sgitario
Copy link
Contributor Author

Tests failures are unrelated. I'm merging this.

@Sgitario Sgitario merged commit 22c6aca into quarkusio:main Sep 22, 2022
@Sgitario Sgitario deleted the support_job branch September 22, 2022 05:48
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 22, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes extension for Command line apps
4 participants