-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC - add debug logging for the request context manipulation #27249
Conversation
mkouba
commented
Aug 11, 2022
- activation, deactivation and destruction
This could be really helpful when debugging issues like #27229. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally say it should be trace logging, but other than that, looks fine.
Ok, let's use the TRACE level. I don't see a big difference here but it makes sense in general. |
0abc74c
to
da220d6
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only added a typo correction.
This comment has been minimized.
This comment has been minimized.
da220d6
to
606ff47
Compare
- activation, deactivation and destruction
606ff47
to
0ae0308
Compare
Failing Jobs - Building 0ae0308
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: devtools/cli integration-tests/rest-client
📦 devtools/cli✖ 📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: devtools/cli integration-tests/rest-client
📦 devtools/cli✖ 📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: devtools/cli extensions/hibernate-search-orm-elasticsearch/deployment integration-tests/rest-client
! Skipped: extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode integration-tests/hibernate-search-orm-elasticsearch and 3 more 📦 devtools/cli✖ 📦 extensions/hibernate-search-orm-elasticsearch/deployment✖ 📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
✖
✖
✖
⚙️ Native Tests - HTTP #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
✖
✖
✖
|
@gastaldi do you happen to know if those tests are a known problem? |
@mkouba never seen those fail before, maybe @michalszynkiewicz knows something? |
Looks like some timeouts, unlikely to be flaky tests but I can see them across several PRs already. Did we cross some timeout limit set for CI? |
Not sure. Now I am seeing these failures in another PRs too, looks like some commit broke it or certificates expired somewhere, I'll investigate |
I think these may be the tests that use badssl.com that @geoand created a while back |
Indeed. There is a script that regenerates those certificates |