Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - add debug logging for the request context manipulation #27249

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 11, 2022

  • activation, deactivation and destruction

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Aug 11, 2022
@mkouba
Copy link
Contributor Author

mkouba commented Aug 11, 2022

This could be really helpful when debugging issues like #27229.

@mkouba mkouba requested review from Ladicek and manovotn August 11, 2022 14:43
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally say it should be trace logging, but other than that, looks fine.

@mkouba
Copy link
Contributor Author

mkouba commented Aug 15, 2022

I'd personally say it should be trace logging, but other than that, looks fine.

Ok, let's use the TRACE level. I don't see a big difference here but it makes sense in general.

@mkouba
Copy link
Contributor Author

mkouba commented Aug 15, 2022

I'd personally say it should be trace logging, but other than that, looks fine.

Done.

@mkouba mkouba requested a review from Ladicek August 15, 2022 12:56
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 15, 2022
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added a typo correction.

docs/src/main/asciidoc/cdi-reference.adoc Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@mkouba mkouba force-pushed the arc-req-context-logging branch from da220d6 to 606ff47 Compare August 16, 2022 05:42
- activation, deactivation and destruction
@mkouba mkouba force-pushed the arc-req-context-logging branch from 606ff47 to 0ae0308 Compare August 16, 2022 05:52
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 16, 2022

Failing Jobs - Building 0ae0308

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs
Native Tests - HTTP Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: devtools/cli integration-tests/rest-client 

📦 devtools/cli

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project quarkus-cli: There was a timeout in the fork

📦 integration-tests/rest-client

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: devtools/cli integration-tests/rest-client 

📦 devtools/cli

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project quarkus-cli: There was a timeout in the fork

📦 integration-tests/rest-client

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/cli extensions/hibernate-search-orm-elasticsearch/deployment integration-tests/rest-client 
! Skipped: extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode integration-tests/hibernate-search-orm-elasticsearch and 3 more

📦 devtools/cli

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project quarkus-cli: There was a timeout in the fork

📦 extensions/hibernate-search-orm-elasticsearch/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.2:start (docker-start) on project quarkus-hibernate-search-orm-elasticsearch-deployment: I/O Error

📦 integration-tests/rest-client

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/rest-client 

📦 integration-tests/rest-client

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client 

📦 integration-tests/rest-client

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs_java_url - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllIT.restClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.it.rest.client.wronghost.ExternalWrongHostIT.restClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

@mkouba
Copy link
Contributor Author

mkouba commented Aug 16, 2022

@gastaldi do you happen to know if those tests are a known problem?

@gastaldi
Copy link
Contributor

@mkouba never seen those fail before, maybe @michalszynkiewicz knows something?

@manovotn
Copy link
Contributor

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project quarkus-cli: There was a timeout in the fork

Looks like some timeouts, unlikely to be flaky tests but I can see them across several PRs already. Did we cross some timeout limit set for CI?

@gastaldi
Copy link
Contributor

Not sure. Now I am seeing these failures in another PRs too, looks like some commit broke it or certificates expired somewhere, I'll investigate

@mkouba mkouba merged commit 944ac8f into quarkusio:main Aug 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 16, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 16, 2022
@michalszynkiewicz
Copy link
Member

I think these may be the tests that use badssl.com that @geoand created a while back

@geoand
Copy link
Contributor

geoand commented Aug 16, 2022

Indeed.

There is a script that regenerates those certificates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants