-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs metadata generation #27233
Conversation
ebullient
commented
Aug 10, 2022
- Summary: Use the first sentence of the preamble or the 'summary' attribute value.
- Use a 'categories' attribute for gross category grouping, including 'get-started' for "Getting Started" / introductory tutorials.
- Summary: Use the first sentence of the preamble or the 'summary' attribute value. - Use a 'categories' attribute for gross category grouping, including 'get-started' for "Getting Started" / introductory tutorials.
52f50de
to
30b8c32
Compare
@ebullient - Looks good 👍 What if both the 'summary' attribute and the asciidoc 'preamble' exist? Which takes precedence and gets added to the "summary:" (formerly "description") bit of the index.yml file, as per the screencap below? Apologies if I missed this in the code. Thanks :-) |
The summary wins. quarkus/docs/src/main/java/io/quarkus/docs/generation/YamlMetadataGenerator.java Line 118 in 30b8c32
|
looks fine - is the output of this hooked into the publishing yet or is that a TDB? |
docs/src/main/java/io/quarkus/docs/generation/YamlMetadataGenerator.java
Show resolved
Hide resolved
@ebullient - FYI and related to this PR: Also... Ideally, the first-sentence summary of the abstract (aka asciidoc preamble) should be less than 26 words. Would it make sense to add a validation check? Thanks. |
Not hooked into publishing yet. All of this is still in-flight / under review. The lastest changes are after reviewing with Michelle, which gave me some ideas for making the intent of some fields easier to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm