Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smallrye-open-api from 2.1.23 to 2.2.0 #27206

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Conversation

MikeEdgar
Copy link
Contributor

@MikeEdgar MikeEdgar commented Aug 9, 2022

Changes from 2.1.23 includes back-ported PRs listed in smallrye/smallrye-open-api#1210

Fixes #27058
Fixes #26546
Fixes #26848
Fixes #21173

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/smallrye labels Aug 9, 2022
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@MikeEdgar MikeEdgar marked this pull request as draft August 10, 2022 00:52
@MikeEdgar
Copy link
Contributor Author

Researching test failures

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 17, 2022

@radcortez it seems HelloRouterTest is failing nearly consistently now. Did you have any chance tracking the cause?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a Jakarta version of this one and an update here: https://github.com/quarkusio/quarkus/blob/main/jakarta/rewrite.yml#L560 in this very PR.

/cc @radcortez

Save method hashes based on resource implementation classes and both the
concrete and (potentially) abstract methods.
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 17, 2022

Failing Jobs - Building 1a37111

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/opentelemetry-vertx 

📦 integration-tests/opentelemetry-vertx

io.quarkus.it.opentelemetry.vertx.HelloRouterTest.bus line 134 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <CONSUMER> but was: <PRODUCER>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/micrometer-prometheus 

📦 integration-tests/micrometer-prometheus

io.quarkus.it.micrometer.prometheus.ClientRequestTest.testClientRequests line 36 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@MikeEdgar MikeEdgar requested a review from gsmet August 18, 2022 11:03
@gsmet gsmet merged commit 7db91d2 into quarkusio:main Aug 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 18, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 18, 2022

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@MikeEdgar MikeEdgar deleted the sroai-2.2.0 branch March 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment