Add Description for Feature classes #27137
Conversation
quarkus-bot
bot
added
area/core
area/hibernate-validator
There was a problem hiding this comment.
This is nice, but shouldn't the links be something more stable? These will break as soon as we change the directory structure in our repo, and that kind of change has been discussed recently.
Maybe a link to the javadoc (which would only depend on the package/class name) would be safer? I couldn't find where the javadoc of Quarkus is published, though...
We could point to a tagged version instead (by having the URL changed during the build) but I am not sure it's worth the effort. We can start by providing only the descriptions now. |
This comment has been minimized.
This comment has been minimized.
|
Very interesting! But I totally agree with @yrodiere that we should add something more stable as the URL. |
Follow up on quarkusio#26943
gastaldi
force-pushed
the
feature_description_url
branch
from
176b810 to
08a6401
Compare
gastaldi
changed the title
|
I reworked the PR to provide only the description for now, until we figure out a stable URL to use |
| InputStream resourceAsStream = getClass().getClassLoader().getResourceAsStream(META_INF_QUARKUS_NATIVE_RESOURCES_TXT); | ||
| if (resourceAsStream != null) { |
There was a problem hiding this comment.
I guess you're also fixing a bug here?
That was unexpected, but ok.
Follow up on #26943
This produces an output during the GraalVM compilation explaining what the Feature does and allows you to browse to the existing source code:
Screen.Recording.2022-08-04.at.11.40.57.mov