Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support count with collation in MongoDB with Panache #27062

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Support count with collation in MongoDB with Panache #27062

merged 1 commit into from
Aug 2, 2022

Conversation

diogocarleto
Copy link
Contributor

@diogocarleto diogocarleto commented Aug 1, 2022 •
edited by gsmet
Loading

This is a fix to allow us execute count queries with collation

Fixes #27063

@diogocarleto diogocarleto mentioned this pull request Aug 1, 2022
Closed
loicmathieu
loicmathieu approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty straigthforward regarding what I did with the find query.
Looks good to me, thanks.

@gsmet gsmet changed the title Mongo db panache bug fix to allow count with collation Support count with collation in MongoDB with Panache Aug 1, 2022
@gsmet gsmet force-pushed the mongoDBPanacheBugFixToAllowCountWithCollation branch from f8ab7ac to d0bb072 Compare August 1, 2022 15:44
@gsmet
Copy link
Member

gsmet commented Aug 1, 2022

I force pushed to squash the commits. Let's wait for CI before merging.

@geoand geoand merged commit c3d0a84 into quarkusio:main Aug 2, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@evanchooly evanchooly evanchooly approved these changes

Assignees
No one assigned
Labels
area/mongodb area/panache kind/bugfix
Projects
None yet
Milestone
2.12.0.CR1
Development

Successfully merging this pull request may close these issues.

Panache MongoDB doesn't support collation in count
5 participants
@diogocarleto @gsmet @evanchooly @loicmathieu @geoand