Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the use of buffers in health reporting #27056

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 1, 2022

This is done by leveraging Vert.x's Buffer directly instead
of relying on a ByteArrayOutputStream which results in
of unnecessary copying of data

This is done by leveraging Vert.x's Buffer directly instead
of relying on a ByteArrayOutputStream which results in a lot
of unnecessary copying of data
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 1, 2022

Failing Jobs - Building 5f67ced

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if the BufferOutputStream should go into a util package somewhere?

@geoand
Copy link
Contributor Author

geoand commented Aug 1, 2022

I thought about that, but I would say let's play it safe and keep it private for now and revise the decision if we need something similar in the future

@geoand geoand merged commit 6365af9 into quarkusio:main Aug 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 1, 2022
@geoand geoand deleted the health-buffer branch August 1, 2022 14:23
@mkouba
Copy link
Contributor

mkouba commented Aug 1, 2022

I thought about that, but I would say let's play it safe and keep it private for now and revise the decision if we need something similar in the future

+1 expect that nobody would know about this class (and you'll probably forget about it in a few months too ;-).

@geoand
Copy link
Contributor Author

geoand commented Aug 1, 2022

That is entirely possible 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants