Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace InputStream bytes with InputStream.readAllBytes in Vert.x #27053

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 1, 2022

This not only results is less code, but it's also more efficient as
it generally results in less array copying

This not only is less code, but it's also more efficient as
it generally results in less array copying
@geoand geoand requested a review from gastaldi August 1, 2022 11:26
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 1, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 1, 2022

Failing Jobs - Building 5026a2d

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompositeBuildWithDependenciesDevModeTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit f224e25 into quarkusio:main Aug 1, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 1, 2022
@geoand geoand deleted the vertx-is branch August 2, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants