Introduce support for ContextResolver<ObjectMapper> in server part of RESTEasy Reactive #26988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RESTEasy Reactive Relates to: quarkusio#26152
|
Would be good to have this in |
gastaldi
reviewed
Aug 2, 2022
...quarkus/resteasy/reactive/jackson/deployment/processor/ResteasyReactiveJacksonProcessor.java
Show resolved
Hide resolved
gsmet
reviewed
Aug 3, 2022
Comment on lines
+100
to
+101
| ContextResolver<ObjectMapper> contextResolver = providers.getContextResolver(ObjectMapper.class, | ||
| context.getResponseMediaType()); |
There was a problem hiding this comment.
It's more of a general question but do you handle @ConstrainedTo for providers in RESTEasy Reactive? (to constrain providers to server/client)
There was a problem hiding this comment.
That's an excellent question, unfortunately this is a limitation of the (pretty bad) JAX-RS Provider API. If you look at javax.ws.rs.ext.Providers, there is way to limit the results using the javax.ws.rs.RuntimeType
There was a problem hiding this comment.
But RESTEasy Classic implements it, I'm sure because I used this feature already.
There was a problem hiding this comment.
Implements what? The constraint? Are you sure?
There was a problem hiding this comment.
Support for @ConstrainedTo. But maybe I misunderstood what you were saying.
Note that it doesn't mean you can't merge this PR, it's just a question that came to mind.
There was a problem hiding this comment.
I don't see @ConstrainedTo being taken into account anywhere in RESTEasy Classic. Do you have an example suggesting otherwise?
gastaldi
approved these changes
Aug 3, 2022
|
Unless there are any objections, I am going to merge this |
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 9, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 10, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 25, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 26, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Aug 26, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
fercomunello
pushed a commit
to fercomunello/quarkus
that referenced
this pull request
Aug 31, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
evanchooly
pushed a commit
to nenros/quarkus
that referenced
this pull request
Sep 8, 2022
With these changes, we can now register custom object mappers when creating a client programmatically:
```
clientAllowsUnknown = RestClientBuilder.newBuilder()
.baseUrl(new URL(wireMockServer.baseUrl()))
.register(ClientObjectMapperUnknown.class)
.build(MyClient.class);
```
where ClientObjectMapperUnknown is:
```
public static class ClientObjectMapperUnknown implements ContextResolver<ObjectMapper> {
@OverRide
public ObjectMapper getContext(Class<?> type) {
return new ObjectMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
}
}
```
I implemented this feature by injecting the rest client context via the interface ClientRestHandler. Then, the rest client context has registered all the context resolvers, so the jackson message reader/writer can get the custom object mappers.
Fix quarkusio#26152
Relates quarkusio#26988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #26152