-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Liquibase to 4.14.0 and resolve most deprecation warnings #26977
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
.collect(Collectors.toSet()); | ||
|
||
resource.produce( | ||
new NativeImageResourceBuildItem(getChangeLogs(dataSourceNames, liquibaseBuildConfig).toArray(new String[0]))); | ||
|
||
Stream.of(liquibase.change.Change.class, | ||
liquibase.changelog.ChangeLogHistoryService.class, | ||
liquibase.command.LiquibaseCommand.class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deprecated, hence also this change: https://github.com/quarkusio/quarkus/pull/26977/files#diff-930f0d68c059b4088f05d8c3d7a725e110279966c77958a6d699f9c652bde81eL48-R47
It was added back in #9636, but I don't see how the following is still the case today:
This capability is also shown in our Liquibase quickstart
...s/liquibase/deployment/src/main/java/io/quarkus/liquibase/deployment/LiquibaseProcessor.java
Show resolved
Hide resolved
Seems reasonable |
Any input from your side @gsmet @loicmathieu? If not I'll go ahead and finish this. |
@famod nothing to say, go ahead ;) |
integration-tests/liquibase/src/main/resources/db/changeLog.xml
Outdated
Show resolved
Hide resolved
Mongo stuff added, ready for final review! |
Failing Jobs - Building 863fa43
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ |
WIP for now because the mongo part is not done yet, which I'd do if we agree that my changes are ok.I'll also squash everything, eventually.
On main thing to keep in mind with this is the following item from the changelog:
so I removed the "pro" stuff.
I'll also leave some review comments...