Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MicroProfile LRA TCK #26913

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Add MicroProfile LRA TCK #26913

merged 1 commit into from
Aug 9, 2022

Conversation

xstefank
Copy link
Member

@xstefank xstefank commented Jul 25, 2022

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/lra area/testing labels Jul 25, 2022
@gsmet
Copy link
Member

gsmet commented Jul 25, 2022

@xstefank I upgraded to 5.12.7 under your feet, sorry. Can you rebase?

@gsmet
Copy link
Member

gsmet commented Jul 25, 2022

Also, yes, please make the upgrade a separate commit.

@xstefank xstefank force-pushed the mp-lra-tck branch 2 times, most recently from a385975 to 09371d2 Compare July 25, 2022 13:30
@xstefank
Copy link
Member Author

@gsmet no worries, happens. I don't think test failures are related. Can I also ask who is the main quarkus-arquillian master to discuss some improvements of this TCK runs?

@xstefank
Copy link
Member Author

xstefank commented Aug 8, 2022

@gsmet just resolved conflict, no need to upgrade narayana anymore here. So only adding the LRA TCK run.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My guess is that it will require some efforts to make it work with the Jakarta effort but I will have a look tomorrow.

@gsmet gsmet merged commit a2be670 into quarkusio:main Aug 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Aug 9, 2022
@xstefank xstefank deleted the mp-lra-tck branch August 10, 2022 05:25
@xstefank
Copy link
Member Author

@gsmet let me know if I can help on that front too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/lra area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants