Rename quarkus.hibernate-search-orm.enabled to quarkus.hibernate-search-orm.active and repurpose quarkus.hibernate-search-orm.enabled to disable Hibernate Search at build time #26840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is two-fold:
.enabled
to enable/disable an extension at build time, but Hibernate Search was using it to disable the extension at runtime. This PR restores consistency.active
solves that.I'm not very enthusiastic about the name of the property=> Renamed toquarkus.hibernate-search-orm.started
, but that's the best I could come up with. I'm open to suggestions, keeping in mind thatquarkus.hibernate-search-orm.enabled
is not an option since it has a different purpose..active
, a bit better.This is related to a conversation we had on the Quarkus mailing list: https://groups.google.com/g/quarkus-dev/c/rfWe_jrSzJY/m/u5282G-SEAAJ?utm_medium=email&utm_source=footer
For context, the conversation branched from there: https://groups.google.com/g/quarkus-dev/c/o8gtDJoV7VY/m/R9ub7DPqAgAJ?utm_medium=email&utm_source=footer
For the migration guide:
Creating as draft because this PR is based on #26838 , which should be merged first.