Actually run the Redis Dev Services tests #26834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were not run at all until now. Also reformat the pom file to follow our conventions and remove a test that can't work: we cannot have the Quarkus server failing in a QuarkusTest.
gsmet
commented
Jul 20, 2022
Comment on lines
+90
to
+116
| <profiles> | ||
| <!-- Note: the container is started via Dev Services --> | ||
| <profile> | ||
| <id>test-redis</id> | ||
| <activation> | ||
| <property> | ||
| <name>test-containers</name> | ||
| </property> | ||
| </activation> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <skip>false</skip> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <configuration> | ||
| <skip>false</skip> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </profile> | ||
| </profiles> |
There was a problem hiding this comment.
This is the actual change. Until now tests were disabled always.
machi1990
approved these changes
Jul 20, 2022
|
|
||
| </project> | ||
| </project> |
There was a problem hiding this comment.
Suggested change
| </project> | |
| </project> | |
cescoffier
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were not run at all until now.
Also reformat the pom file to follow our conventions and remove a test
that can't work: we cannot have the Quarkus server failing in a
QuarkusTest.