Consistently consider quoted AND non-quoted versions of quarkus.datasource configuration properties #26815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/config
area/core
area/hibernate-orm
|
As to why this fixes #26507, I'm not completely sure, but it does. I suspect there's another problem somewhere, with code that confuses the PU name and the datasource name, and somehow that problem isn't visible anymore once we apply this fix. This will probably warrant more investigation, but I'd say we should merge this fix ASAP, because it makes sense on its own, and it does fix the symptoms, at least. |
gsmet
approved these changes
Jul 19, 2022
This comment has been minimized.
This comment has been minimized.
|
CI looks quite unhappy :). |
…ource configuration properties We were already taking both versions into account in DevServicesDatasourceConfigurationHandlerBuildItem, but not in every other place.
yrodiere
force-pushed
the
i26507-datasource-pu-name
branch
from
a0197ee to
52925f7
Compare
|
It was a copy paste error (using jdbc.url for reactive dev services...). For some reason those test failures seem to have a cascading effect on other tests using docker... Let's see how it goes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already taking both versions into account in
DevServicesDatasourceConfigurationHandlerBuildItem, but not in everyother place.
Fixes #26507