-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Instant.EPOCH when adding docker layers #26758
Conversation
@geoand just created a new PR with the squashed commits |
Thanks, I'll take a closer look on Monday |
Use Instant.EPOCH when adding docker layers so if the content of the files do not change the layer digest doesn't change either
I rebased to trigger CI, which was somehow not triggered. |
I'll review next week when I'm back (hopefully) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor nitpick
...age-jib/deployment/src/main/java/io/quarkus/container/image/jib/deployment/JibProcessor.java
Show resolved
Hide resolved
Thanks for your contribution @fbotis 🎉 ! |
Happy to help! Looking forward creating the next PR :) |
Use Instant.EPOCH when adding docker layers so if the content of the files do not change the layer digest doesn't change either
fixes: 26734