-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Quartz extension as stable #26709
Conversation
Probably a good idea to check with @mkouba before promoting it. |
Thanks @gsmet, I fixed the commit message too 😉 |
Makes sense to me, but let's let @mkouba and @machi1990 weigh in here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on my side.
The API has been stable for quite some time now.
On top of the change in the extensin config yaml, we'll also need to remove the preview status from the doc: https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/quartz.adoc.
extensions/quartz/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
This promotes the extension status from preview to stable
Good for me but let's wait Martin's opinion on this.
@mkouba we waited for you on this one :). |
@gsmet I'm personally +0 on this one. It's true that our API can be considered stable but there are some Quartz features which are not extensively tested (such as clustering) and thus our support is "limited". OTOH if @machi1990 thinks that it's stable then I'm in as well :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's proceed then.
I decided to revert that for now, pending we have a clear status about Quartz + Jakarta. |
This promotes the extension status from preview to stable