Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Quartz extension as stable #26709

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

gastaldi
Copy link
Contributor

This promotes the extension status from preview to stable

@gastaldi gastaldi requested a review from geoand July 13, 2022 12:16
@gsmet gsmet changed the title Quarkus extension is stable Quartz extension is stable Jul 13, 2022
@gastaldi gastaldi requested a review from gsmet July 13, 2022 12:17
@gsmet
Copy link
Member

gsmet commented Jul 13, 2022

Probably a good idea to check with @mkouba before promoting it.

@gastaldi
Copy link
Contributor Author

Thanks @gsmet, I fixed the commit message too 😉

@gastaldi gastaldi requested review from mkouba and removed request for geoand July 13, 2022 12:17
@geoand
Copy link
Contributor

geoand commented Jul 13, 2022

Makes sense to me, but let's let @mkouba and @machi1990 weigh in here

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on my side.

The API has been stable for quite some time now.

On top of the change in the extensin config yaml, we'll also need to remove the preview status from the doc: https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/quartz.adoc.

gsmet
gsmet previously requested changes Jul 19, 2022
docs/src/main/asciidoc/quartz.adoc Outdated Show resolved Hide resolved
This promotes the extension status from preview to stable
@gastaldi gastaldi requested a review from gsmet July 19, 2022 13:13
@gsmet gsmet dismissed their stale review July 19, 2022 17:33

Good for me but let's wait Martin's opinion on this.

@gsmet
Copy link
Member

gsmet commented Jul 25, 2022

@mkouba we waited for you on this one :).

@mkouba
Copy link
Contributor

mkouba commented Jul 26, 2022

@mkouba we waited for you on this one :).

@gsmet I'm personally +0 on this one. It's true that our API can be considered stable but there are some Quartz features which are not extensively tested (such as clustering) and thus our support is "limited".

OTOH if @machi1990 thinks that it's stable then I'm in as well :-)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's proceed then.

@gsmet gsmet dismissed machi1990’s stale review July 26, 2022 14:13

Addressed.

@gsmet gsmet merged commit cd5accc into quarkusio:main Jul 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 26, 2022
@gsmet gsmet changed the title Quartz extension is stable Mark Quartz extension as stable Jul 26, 2022
@gsmet
Copy link
Member

gsmet commented Aug 23, 2022

I decided to revert that for now, pending we have a clear status about Quartz + Jakarta.

@gastaldi gastaldi deleted the promote_quartz branch September 5, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants