Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code 1 in CI step 'Get GIB impacted modules' on jakarta-rewrite branch #26708

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix exit code 1 in CI step 'Get GIB impacted modules' on jakarta-rewrite branch #26708

merged 1 commit into from
Jul 13, 2022

Conversation

famod
Copy link
Member

@famod famod commented Jul 13, 2022

Related to #26663

gib-impacted.log can be empty when GIB bailed out due to e.g.:

[INFO] gitflow-incremental-builder execution skipped: Changed path matches regex defined by skipIfPathMatches: .github/workflows/ci-actions-incremental.yml

This is a problem for that grep execution because it will return with exit code 1 when nothing matched.
Changing the if predicate -f to -s would be enough to fix that.

But grep will also return 1 if nothing is left, e.g. when only integration-tests/infinispan-client and/or integration-tests/kafka-avro were changed.
Therefore I replaced grep with sed (which doesn't care whether or not the respective lines are present).

@famod famod requested a review from gsmet July 13, 2022 11:25
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jul 13, 2022
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that was all my fault, thanks for having a look.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2022
@famod
Copy link
Member Author

famod commented Jul 13, 2022

It's just too easy to miss those things!

@gastaldi gastaldi merged commit fcf09df into quarkusio:main Jul 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 13, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2022
@famod famod deleted the ci-gib-jakarta-fix branch July 13, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants