Fix exit code 1 in CI step 'Get GIB impacted modules' on jakarta-rewrite branch #26708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #26663
gib-impacted.log
can be empty when GIB bailed out due to e.g.:This is a problem for that
grep
execution because it will return with exit code 1 when nothing matched.Changing the
if
predicate-f
to-s
would be enough to fix that.But
grep
will also return 1 if nothing is left, e.g. when onlyintegration-tests/infinispan-client
and/orintegration-tests/kafka-avro
were changed.Therefore I replaced
grep
withsed
(which doesn't care whether or not the respective lines are present).