-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Basic Authentication section #26697
Improve the Basic Authentication section #26697
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
d6271ce
to
f603cc3
Compare
Hi @MichalMaler , A few comments on the form of the pull request:
If you form your commit comment like:
(note the blank line, it's important) Then GitHub will automatically fill the fields appropriately when creating the pull request if you have only one commit and your work will be easier. /cc @ebullient @quarkusio/documentation for general awareness. |
|
||
In the context of an HTTP request, basic access authentication is a method for an HTTP user agent (such as a Web browser) to provide a user name and password when making a request. In basic HTTP authentication, a request contains a header field in the form of _Authorization: Basic_ _<credentials>_, where credentials are the Base64 encoding of a user ID and password joined by a colon. | ||
|
||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never used this construct without an admonition type (e.g. [NOTE]
) so we need to check how it renders on the website.
/cc @ebullient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet Do you mean this one, _Authorization: Basic_ _<credentials>_
?
I'd just go for a simple highlighting like Authorization: Basic <credentials>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sberyozkin I think he was talking about the ==== box I used to highlight the example.
The underscores mean a plain italic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, what @MichalMaler said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authorization: Basic <credentials>
should be inline code, rather than italics, I believe.
Without the type (e.g. NOTE), it is a simple admonition that should render as a plain callout box, but we will have to see what the web CSS does with it.
f603cc3
to
a97cc7c
Compare
@gsmet Hello there. Thank you for the feedback. I applied what I could. Let see how it looks on the portal and if Erin will like it. Cheers! |
1f7db44
to
14f83ec
Compare
@MichalMaler yeah, you need to do a full build first. Do a Then you can iterate on the docs module as you wanted to do it without doing a full build every time. You might have to do it from time to time when we add a new module but it doesn't happen that often these days so you should be pretty much OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichalMaler Thank you for creating this PR. The changes look great.
I'm adding a few suggestions to the changes to align with the style guide, please take a look and let me know if you've any questions.
14f83ec
to
55ba072
Compare
55ba072
to
5cf1067
Compare
Signed-off-by: Michal Maléř <[email protected]>
5cf1067
to
14a528f
Compare
@MichalMaler @hmanwani-rh Thanks very much for this effort, LGTM, sorry if some of my suggestions look a bit pedantic. Your PR improves Basic Authentication related documentation a lot. I guess it is only the first step, eventually it will be moved into the dedicated doc(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this is a first pass at revising an existing doc, right? (I think I remember this).. we're kind of in the fuzzy middle to me on this one (a cross between a how-to and an explanation... )
LGTM, I can merge shortly, my understanding is that right now the task is about getting the content right, the actual restructuring to align with new templates will follow up |
@ebullient right, just saw your comment, yes, that is my understanding too. The fist pass is about revising the current content for different security documents, preparing them really for the next phase and then in the next phase it will be a matter of moving the chunks of content around to align with the new model |
Improve the Basic Authentication section
Adding intro for the BA section and also the information about how to configure it.
Close:
https://issues.redhat.com/browse/QDOCS-27
https://issues.redhat.com/browse/QDOCS-28