Fix createLiquibase mongodb connection string handling #26684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
paloliska
changed the title
gsmet
changed the title
This comment has been minimized.
This comment has been minimized.
|
I force pushed to rebase and fix the formatting issues. |
@gsmet thank you |
loicmathieu
approved these changes
Jul 13, 2022
|
@loicmathieu @gsmet should we backport this fix on pre-2.11 Quarkus? |
|
@gastaldi we can but it's an enhancement so maybe it's not worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of mongodb connection string now preserves connection options in LiquibaseMongodbFactory.createLiquibase()
Fixes #26655